Add long press action on hashtags and web links in descriptions

[AudricV]

What is it?

• Feature (user facing)

Description of the changes in your PR

This PR adds a long press action on web links and hashtags which copy them to clipboard.

To do so:

• Some changes in our TextView class have been required and metadata items are now using a NewPipeTextView instead of a standard TextView.

• Three new classes have been added: a custom LinkMovementMethod class (adapted from a StackOverflow answer), a custom ClickableSpan class have been added in order to set a long press event and a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils.

Before/After Screenshots/Screen Record

• Before:

Long.press.links.and.hashtags.before.mp4

• After:

Long.press.links.and.hashtags.after.mp4

Fixes the following issue(s)

• Fixes Links in description can't be copied #3253

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[litetex]

Note:

• The videos are unplayable (can't view them in Firefox or Chromium-based browsers)
• There are some Sonar warnings

[AudricV]

• The videos are unplayable (can't view them in Firefox or Chromium-based browsers)

I had to compress them, unfortunately, but it seems Video Transcoder converted them in an unplayable format for browsers (you can play them in VLC I think)

[SameenAhnaf]

@litetex You may download the video with Video Download Helper. I eventually had to download, the video is still loading on my browser.

@TiA4f8R I included some suggestions in #7097. I think, it'll be more suitable for copying links.

[AudricV]

So what's the best way to proceed when long pressing links and hashtags?

• copy them directly to clipboard
• show an alert dialog to allow opening/searching them and copying them to clipboard

I am not all a UX designer so feedback is appreciated.

[opusforlife2]

@TiA4f8R The usual behaviour for Android apps is to take the specific action when directly tapping, and to copy to clipboard (or something else) when long-pressing.

[AudricV]

Ok, I will do this.

Edit: done

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

[ktprograms]

@TiA4f8R Can you please add this functionality to timestamps in the description? (Example video with timestamps: https://www.youtube.com/watch?v=mOSirVeP5lo)

Thanks!

[Stypox]

Looks almost good to me ;-)

[AudricV]

Note: even if it seems I forgot this pull request, I didn't forget it and I will continue to work on this, maybe once my work is done on other features/bug fixes I have on NewPipe projects.

[AudricV]

@TiA4f8R Can you please add this functionality to timestamps in the description? (Example video with timestamps: https://www.youtube.com/watch?v=mOSirVeP5lo)

Thanks!

@ktprograms Done (in the app side) on services on which timestamps supported (otherwise, a fallback to copy timestamp raw text is made).

[AudricV]

Note that the Sonar bug is a false positive, as nullity is checked by Utils.isBlank method of the extractor as the first instruction of the method and that the TODO that I added, is of course, not feasible in this PR.

[sonarcloud]

SonarCloud Quality Gate failed.   

1 Bug
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

At this point you should probably create a library for clipboard & sharing handling 😂

I tested on API 33 emulated, API 22 emulated and my API 29 phone and everything works well. Comments with links now behave correctly :-D

The few comments I left are really small things: once you solve them, you can merge this PR yourself. Code looks good. I rebased and solved conflicts, otherwise it wouldn't build, because of the missing extractor commit build on Jitpack.

[sonarcloud]

SonarCloud Quality Gate failed.   

1 Bug
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

LGTM, thanks! The bug reported by Sonar is wrong: it says content might be null but actually we check for isBlankness above.

[goyalyashpal]

• The videos are unplayable (can't view them in Firefox or Chromium-based browsers)
  - @ litetex at Add long press action on hashtags and web links in descriptions #7725 (review)

kinda strange that yeah, it doesn't play on desktop browser ( Vivaldi | 5.5.2805.48 (Stable channel) (64-bit) ; Chrome/106.0.0.0), but is working fine on android browser (Vivaldi 5.6.2868.29)

[goyalyashpal]

but i still don't understand the premise of this PR.

like, selecting tags and links was available before this pr as well:

• "Enable selecting text in description"
• press and hold on links to select and copy them
• the only problem was that clicking them caused them to open

This pr shows that press and holding them automatically copies them - one tap saved.

But what happens in this pr when u single tap on links/tags? Did this problem was an effort to solve this single tap problem?

Following is a screenrecord from Newpipe v0.23.3 i.e. back from 2022.08'

v0.23.3-newpipe.mp4

[Stypox]

The videos are unplayable

I don't understand what you are referring to.

Did this problem was an effort to solve this single tap problem?

What do you mean by "single tap problem"? For me single taps work normally. Also, this PR was also needed because soon we will have comments with copiable links and hashtags.

[goyalyashpal]

I don't understand what you are referring to.

sorry, have updated with link. : #7725 (review)

single tap problem"? For me single taps work normall

this is shown in the screen recording - i meant that on single tapping, the links were opening. i was asking that was that considered the problem?

Also, this PR was also needed because soon we will have comments with copiable links and hashtags.

yeah, that is understandable. the thing that confused me was the following quoted part: "reopening as we are not able to copy full links" which we definitely were.

Reopening as we are not able to copy full links on YouTube. I will open a PR which will add this ability soon.
- @ AudricV at #3253 (comment)

[Stypox]

which we definitely were

Oh ok, I see what you meant. Yeah, in the description you were already able to copy YouTube links, since those are always shown in full. I am not sure about Peertube though, where Markdown is employed, and [link](https://example.org) gets transformed into the literal "link". Unless Android is able to copy rich text, I doubt you would be able to copy links from there. So the YouTube description was just a special case among other services' descriptions and also comments.

[goyalyashpal]

about Peertube though, where Markdown is employed,
Unless Android is able to copy rich text,

ohw ohkayh, yeah, makes sense then 👍