Trim search string and remove duplicate records from the database

[dtcxzyw]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Strip leading and trailing white spaces of search string before passing it into suggestionPublisher after typing or pasting text
• Trim the search string of the search bar when the user presses search
• Add new database migration to remove duplicate records in search history
• Add a test for the database migration

Before/After Screenshots/Screen Record

• Before:

before.mp4

• After:

after.mp4

Fixes the following issue(s)

• Fixes Trim trailing/preceding whitespaces from search inputs #8012

APK testing

Debug APK

Due diligence

• I read the contribution guidelines.

[tsiflimagas]

Migration worked great, and trimming also works as expected. Thank you!

[litetex]

@TiA4f8R
Do we really need a database migration for this?
The users can simply delete their search history and the problems should be gone.
Looks a little bit overkill to me, also regarding the fact that it doesn't affect that many users.

Without the database migration, only a single class is affected, now we have 6...

[AudricV]

@TiA4f8R
Do we really need a database migration for this?

Disclaimer: the idea is not from me but from @TobiGr:

the dev might want to add a migration finding duplicate entries in the search history and delete them, leaving just the trimmed one

[TobiGr]

@litetex I personally do not like to leave it up to the user to clean up the database to contain expected values.
It's better to know exactly how the data is structured. It's just the search history, but we should keep the db clean. I've learned that the hard way... (not in this project though)

[dtcxzyw]

I don't think it's a good idea to have the user manually clear the search history for this feature. Actually, NewPipe works fine with or without database migrations because the PR does not add a unique constraint to the search fields.

[Stypox]

I agree the database migration should be done, to keep data consistent

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

outdated / applied

[TobiGr]

Thank you for the initial work!