Adapt opacity of popup close button to allow touches in other apps on Android >=12

[AudricV]

What is it?

• Bugfix (user facing)

Description of the changes in your PR

This PR sets the opacity, on Android 12 and higher, of the popup close button to the maximum one which allows touches on other apps for these Android versions.

See the documentation of the FLAG_NOT_TOUCHABLE flag, used in the popup close button, for more details.

These changes have been tested on an Android 12 emulator and by several users (from the corresponding issue and from Reddit) and the changes restore the ability to interact with other apps on Android 12 (and probably higher, I didn't test the changes on Android 13 Developer Previews at all).

Before/After Screenshots/Screen Record

Remember that these changes only apply on Android 12 and higher.

• Before:

  

• After:

  

Fixes the following issue(s)

• Fixes Can't interact with app/screen below popup player on Android 12 #6770

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Looks good to me, thank you!

[litetex]

A pretty small fix for a pretty big problem.
This is too good to be true, but it looks like it is.

LGTM

Good work!

[litetex]

@TiA4f8R
I have one question though: Why is the full opacity player not a problem?

[AudricV]

@litetex

I don't really know what to say:

• this should not really work according to the rule Multiple SAW windows with enough transparency described in the FLAG_NOT_TOUCHABLE flag, unless this rule only applies for windows with this flag, which seems to be the case (in this case, the documentation is not clear at all...);
• if we are in the case above, the first part of the rule One SAW window with enough transparency is now respected and the second part seems to be respected since the beginning (maybe not when the popup player itself and the close button are overlapping): the rule One SAW window with enough transparency is now fully respected and the touch events are delivered.

[rawlife56]

@TiA4f8R The touch inputs are not still working in some protected screens like Google Play Store, app updates, Google app security settings screen. Is this expected behavior?

Even if the player is in the background, the touch inputs are blocked and showing this error message 'Looks like another app is blocking access to Google Play. Turn off any apps that might be drawing'

Screenshot (error message at the bottom)

[Bruceforce]

@rawlife56 this was/is also the case for Android 11 (at least for me) so this would be a separate issue in my opinion.

[rawlife56]

@rawlife56 this was/is also the case for Android 11 (at least for me) so this would be a separate issue in my opinion.

Good to know. Couldn't test as there wasn't any A11 device around. Hopefully work on native PIP mode support wouldn't be less prioritized.