Use range-limiting methods.

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use range-limiting methods, such as MathUtils.clamp() and Kotlin's coerceIn().

Fixes the following issue(s)

• Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

Nice catch ;-)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Again some code style issues I fixed myself, but this is ready (I tested, for example, the popup and found no issues)

[Stypox]

Suggested change

	// Use 1/4 of the width for the preview
	final int newWidth = MathUtils.clamp(Math.round(baseViewWidthSupplier.getAsInt() / 4f),
	DeviceUtils.dpToPx(10, context),
	// Scaling more than that factor looks really pixelated -> max
	Math.round(srcWidth * 2.5f));
	final int newWidth = MathUtils.clamp(
	// Use 1/4 of the width for the preview
	Math.round(baseViewWidthSupplier.getAsInt() / 4f),
	// But have a min width of 10dp
	DeviceUtils.dpToPx(10, context),
	// And scaling more than that factor looks really pixelated -> max
	Math.round(srcWidth * 2.5f));

[Stypox]

Suggested change

	public int interpolateOutOfBoundsScroll(@NonNull final RecyclerView recyclerView,
	final int viewSize, final int viewSizeOutOfBounds,
	final int totalSize, final long msSinceStartScroll) {
	public int interpolateOutOfBoundsScroll(@NonNull final RecyclerView recyclerView,
	final int viewSize,
	final int viewSizeOutOfBounds,
	final int totalSize,
	final long msSinceStartScroll) {

[Stypox]

I got a crash while testing #8656 related to this PR:

• start playing in a popup in portrait
• rotate the phone to landscape
• hold the popup to have it enlarged
• try to move the popup

java.lang.IllegalArgumentException: Cannot coerce value to an empty range: maximum -175.0 is less than minimum 0.0.
        at kotlin.ranges.RangesKt___RangesKt.coerceIn(_Ranges.kt:1131)
        at org.schabi.newpipe.player.gesture.PopupPlayerGestureListener.onScroll(PopupPlayerGestureListener.kt:241)
        at android.view.GestureDetector.onTouchEvent(GestureDetector.java:704)
        at org.schabi.newpipe.player.gesture.BasePlayerGestureListener.onTouch(BasePlayerGestureListener.kt:27)
        at org.schabi.newpipe.player.gesture.PopupPlayerGestureListener.onTouch(PopupPlayerGestureListener.kt:34)
        at android.view.View.dispatchTouchEvent(View.java:14536)
        at ...

So this PR introduced possible crashes. Could you revert all usages of range-limiting methods in cases where the two extrema are not surely one smaller than the other?

[Isira-Seneviratne]

I got a crash while testing #8656 related to this PR:

• start playing in a popup in portrait
• rotate the phone to landscape
• hold the popup to have it enlarged
• try to move the popup

java.lang.IllegalArgumentException: Cannot coerce value to an empty range: maximum -175.0 is less than minimum 0.0.
        at kotlin.ranges.RangesKt___RangesKt.coerceIn(_Ranges.kt:1131)
        at org.schabi.newpipe.player.gesture.PopupPlayerGestureListener.onScroll(PopupPlayerGestureListener.kt:241)
        at android.view.GestureDetector.onTouchEvent(GestureDetector.java:704)
        at org.schabi.newpipe.player.gesture.BasePlayerGestureListener.onTouch(BasePlayerGestureListener.kt:27)
        at org.schabi.newpipe.player.gesture.PopupPlayerGestureListener.onTouch(PopupPlayerGestureListener.kt:34)
        at android.view.View.dispatchTouchEvent(View.java:14536)
        at ...

So this PR introduced possible crashes. Could you revert all usages of range-limiting methods in cases where the two extrema are not surely one smaller than the other?

Sure.