Show toast when no updates are available. #8668

Isira-Seneviratne · 2022-07-21T02:48:30Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Display a toast if no new versions of NewPipe are available when checking for updates.

Before/After Screenshots/Screen Record

Before:
After:

Fixes the following issue(s)

Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

TacoTheDank · 2022-07-21T06:02:58Z

Wouldn't this show every time the app is launched? That would be pretty annoying, I think.

triallax · 2022-07-21T14:43:23Z

I agree with @TacoTheDank, it makes little sense to me to show a notification if there is no update available, plus it would be quite irritating. What problem are you trying to solve by this PR @Isira-Seneviratne?

Isira-Seneviratne · 2022-07-21T14:45:14Z

I agree with @TacoTheDank, it makes little sense to me to show a notification if there is no update available, plus it would be quite irritating. What problem are you trying to solve by this PR @Isira-Seneviratne?

The idea was to show some feedback if no update was available, since at the moment nothing is shown if the app is up-to-date.

triallax · 2022-07-21T14:46:27Z

I think that would be more suited for a update check button/page perhaps.

TobiGr · 2022-07-21T15:01:45Z

I would not show a notification, but rather a toast. A toast saying "Checking for updates..." is already shown when the "check for updates" button is pressed (settings > updates).
I agree with the others that this info should not be shown when the check was performed automatically.

Isira-Seneviratne · 2022-07-22T14:13:14Z

@TobiGr Yeah, I'll make that change.

Stypox

Looks almost good to me

Stypox · 2022-08-04T13:52:50Z

app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java

@@ -32,7 +32,7 @@ private void checkNewVersionNow() {
        // Reset the expire time. This is necessary to check for an update immediately.
        defaultPreferences.edit()
                .putLong(getString(R.string.update_expiry_key), 0).apply();
-        NewVersionWorker.enqueueNewVersionCheckingWork(getContext());
+        NewVersionWorker.enqueueNewVersionCheckingWork(requireContext(), true);


I think you should use the MANUAL flag inside NewVersionWorker.checkNewVersion to determine whether to ignore the expiry time, instead of resetting the expiry time here. Also, since only one statement would be left here then, I would remove checkNewVersionNow() and inline the work enqueueing.

app/src/main/res/values/strings.xml

Stypox · 2022-08-06T09:20:01Z

app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt

+            if (isManual) {
+                PreferenceManager.getDefaultSharedPreferences(context).edit {
+                    putLong(context.getString(R.string.update_expiry_key), 0)
+                }
+            }


This is not what I meant: remove this and just add an if (!manual) around these lines

Is the change okay?

Stypox

I get the following error, probably the wrong thread or context are used?

java.lang.NullPointerException: Can't toast on a thread that has not called Looper.prepare()
        at ...
        at org.schabi.newpipe.NewVersionWorker.compareAppVersionAndShowNotification(NewVersionWorker.kt:49)

Stypox · 2022-08-06T21:07:56Z

app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt

@@ -42,26 +44,30 @@ class NewVersionWorker(
        versionCode: Int
    ) {
        if (BuildConfig.VERSION_CODE >= versionCode) {
+            if (inputData.getBoolean(IS_MANUAL, false)) {
+                // Show toast stating that the app is up-to-date if the update check was manual.
+                Toast.makeText(applicationContext, R.string.app_update_unavailable_toast, Toast.LENGTH_SHORT).show()


No lines longer than 100 characters... ktlint seems to be misconfigured, it should detect these problems

Suggested change

Toast.makeText(applicationContext, R.string.app_update_unavailable_toast, Toast.LENGTH_SHORT).show()

Toast.makeText(applicationContext, R.string.app_update_unavailable_toast,

Toast.LENGTH_SHORT).show()

app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt

Stypox · 2022-08-06T21:11:13Z

app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java

@@ -16,25 +16,17 @@ public class UpdateSettingsFragment extends BasePreferenceFragment {
                .apply();

        if (checkForUpdates) {
-            checkNewVersionNow();
+            NewVersionWorker.enqueueNewVersionCheckingWork(requireContext(), true);


I would make this false intead of true, since the user did not directly ask for an update check, he just enabled them. So if the last check was done a while ago (or never), then it's ok to check again, but if it has been done minutes earlier since the user just disabled and enabled twice in a row, it should not be done. Also, it's better to consider it automatic since we don't want a toast to be shown to the user in this case, as he does not expect feedback I think.

I'd keep this true because the user enabled the check manually, in other words wants NewPipe to check for new versions. Reporting back, that we did not find any new version this time is ok. It shows that the app does something as requested.

app/src/main/res/values/strings.xml

Isira-Seneviratne · 2022-08-06T22:19:05Z

I get the following error, probably the wrong thread or context are used?

java.lang.NullPointerException: Can't toast on a thread that has not called Looper.prepare()
        at ...
        at org.schabi.newpipe.NewVersionWorker.compareAppVersionAndShowNotification(NewVersionWorker.kt:49)

Yeah, it seems like the fix is to use a Handler or Executor to show the toast.

By the way, how can I check for updates in the debug build?

TacoTheDank · 2022-08-11T19:30:32Z

By the way, how can I check for updates in the debug build?

I would assume that debug builds are for debugging, and that update checking isn't needed for them.

Isira-Seneviratne · 2022-08-11T22:58:48Z

By the way, how can I check for updates in the debug build?

I would assume that debug builds are for debugging, and that update checking isn't needed for them.

Right, my bad. I'll check with a release build. It's been a while since I made changes to the update process.

sonarcloud · 2022-08-15T02:11:56Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

TobiGr

LGTM. Thank you

TobiGr · 2022-10-09T18:09:34Z

btw. a rebase is required. I just pulled the latest translations from weblate.

To the maintainer merging this PR: please make sure to sync weblate once this PR is merged

sonarcloud · 2022-10-10T01:02:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Stypox

Thanks!

Co-authored-by: Stypox <stypox@pm.me>

Stypox · 2022-12-04T11:02:55Z

I merged weblate into dev, then rebased this PR onto dev, then I'm merging it.

sonarcloud · 2022-12-04T11:10:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Isira-Seneviratne marked this pull request as ready for review July 21, 2022 02:48

Isira-Seneviratne force-pushed the Show_no_update_notification branch from 4ea9012 to b8d95ad Compare August 1, 2022 03:01

Isira-Seneviratne changed the title ~~Show notification when no updates are available.~~ Show toaster when no updates are available. Aug 4, 2022

Stypox requested changes Aug 4, 2022

View reviewed changes

triallax added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Aug 4, 2022

Isira-Seneviratne changed the title ~~Show toaster when no updates are available.~~ Show toast when no updates are available. Aug 5, 2022

Isira-Seneviratne force-pushed the Show_no_update_notification branch from 2d66f2b to 6ca5b41 Compare August 5, 2022 01:19

Stypox requested changes Aug 6, 2022

View reviewed changes

Isira-Seneviratne force-pushed the Show_no_update_notification branch from 7621517 to 012e9ef Compare August 8, 2022 00:55

Isira-Seneviratne force-pushed the Show_no_update_notification branch from 012e9ef to f05fd3e Compare August 15, 2022 01:59

TobiGr approved these changes Oct 9, 2022

View reviewed changes

TobiGr requested a review from Stypox October 9, 2022 17:47

Isira-Seneviratne force-pushed the Show_no_update_notification branch from f05fd3e to 99a4e7b Compare October 10, 2022 00:54

peat80 mentioned this pull request Oct 23, 2022

Show a toast notification when check for updates is manually clicked #9175

Closed

6 tasks

killerrook mentioned this pull request Oct 24, 2022

Toast notification when an update is available #9192

Open

6 tasks

Stypox approved these changes Dec 4, 2022

View reviewed changes

Stypox force-pushed the Show_no_update_notification branch from 99a4e7b to e2670ac Compare December 4, 2022 10:57

Isira-Seneviratne and others added 2 commits December 4, 2022 12:01

Show toast when no updates are available.

f1b15a9

Co-authored-by: Stypox <stypox@pm.me>

Apply ktlint formatting.

6b210e1

Stypox force-pushed the Show_no_update_notification branch from e2670ac to 6b210e1 Compare December 4, 2022 11:02

Stypox merged commit 730664e into TeamNewPipe:dev Dec 4, 2022

Isira-Seneviratne deleted the Show_no_update_notification branch December 6, 2022 14:49

Stypox mentioned this pull request Jan 22, 2023

Release v0.25.0 (please TEST!) #9712

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show toast when no updates are available. #8668

Show toast when no updates are available. #8668

Isira-Seneviratne commented Jul 21, 2022 •

edited

TacoTheDank commented Jul 21, 2022

triallax commented Jul 21, 2022

Isira-Seneviratne commented Jul 21, 2022

triallax commented Jul 21, 2022 •

edited

TobiGr commented Jul 21, 2022 •

edited

Isira-Seneviratne commented Jul 22, 2022

Stypox left a comment

Stypox Aug 4, 2022

Stypox Aug 6, 2022

Isira-Seneviratne Aug 6, 2022

Stypox left a comment •

edited

Stypox Aug 6, 2022

Stypox Aug 6, 2022

TobiGr Oct 9, 2022

Isira-Seneviratne commented Aug 6, 2022

TacoTheDank commented Aug 11, 2022

Isira-Seneviratne commented Aug 11, 2022 •

edited

sonarcloud bot commented Aug 15, 2022

TobiGr left a comment

TobiGr commented Oct 9, 2022

sonarcloud bot commented Oct 10, 2022

Stypox left a comment

Stypox commented Dec 4, 2022

sonarcloud bot commented Dec 4, 2022

	Toast.makeText(applicationContext, R.string.app_update_unavailable_toast, Toast.LENGTH_SHORT).show()
	Toast.makeText(applicationContext, R.string.app_update_unavailable_toast,
	Toast.LENGTH_SHORT).show()

Show toast when no updates are available. #8668

Show toast when no updates are available. #8668

Conversation

Isira-Seneviratne commented Jul 21, 2022 • edited

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

Due diligence

TacoTheDank commented Jul 21, 2022

triallax commented Jul 21, 2022

Isira-Seneviratne commented Jul 21, 2022

triallax commented Jul 21, 2022 • edited

TobiGr commented Jul 21, 2022 • edited

Isira-Seneviratne commented Jul 22, 2022

Stypox left a comment

Choose a reason for hiding this comment

Stypox Aug 4, 2022

Choose a reason for hiding this comment

Stypox Aug 6, 2022

Choose a reason for hiding this comment

Isira-Seneviratne Aug 6, 2022

Choose a reason for hiding this comment

Stypox left a comment • edited

Choose a reason for hiding this comment

Stypox Aug 6, 2022

Choose a reason for hiding this comment

Stypox Aug 6, 2022

Choose a reason for hiding this comment

TobiGr Oct 9, 2022

Choose a reason for hiding this comment

Isira-Seneviratne commented Aug 6, 2022

TacoTheDank commented Aug 11, 2022

Isira-Seneviratne commented Aug 11, 2022 • edited

sonarcloud bot commented Aug 15, 2022

TobiGr left a comment

Choose a reason for hiding this comment

TobiGr commented Oct 9, 2022

sonarcloud bot commented Oct 10, 2022

Stypox left a comment

Choose a reason for hiding this comment

Stypox commented Dec 4, 2022

sonarcloud bot commented Dec 4, 2022

Isira-Seneviratne commented Jul 21, 2022 •

edited

triallax commented Jul 21, 2022 •

edited

TobiGr commented Jul 21, 2022 •

edited

Stypox left a comment •

edited

Isira-Seneviratne commented Aug 11, 2022 •

edited