Use ListAdapter in NotificationModeConfigAdapter. #8841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
AudricV
added
the
codequality
Stypox
requested changes
Nov 22, 2022
app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationModeConfigFragment.kt
Outdated
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Notification_mode_ListAdapter
branch
from
3dbdecd
to
e9b7da3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
requested changes
Dec 28, 2022
There was a problem hiding this comment.
It does not work. Just open "Settings -> Notifications -> Channels" and tick a checkbox to see that everything disappears or the app crashes. Please test your PRs before submitting them (and before submitting any further change), otherwise it's just a waste of time to review things that don't work.
Another thing that you should do is make sure the CI succeeds. In this case it does not succeed because of a misformatted Kotlin file.
Isira-Seneviratne
force-pushed
the
Notification_mode_ListAdapter
branch
from
e9b7da3
to
fb1360b
Compare
|
@Stypox Sorry about that, fixed. |
Stypox
approved these changes
Jan 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
ListAdapterin the notification mode adapter.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence