Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LinkifyCompat. #8934

Merged
merged 1 commit into from Oct 9, 2022
Merged

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Sep 6, 2022

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Use LinkifyCompat to backport Linkify improvements for older API levels.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@opusforlife2
Copy link
Collaborator

to backport Linkify improvements

Idle curiosity. What are these improvements?

@Isira-Seneviratne
Copy link
Member Author

to backport Linkify improvements

Idle curiosity. What are these improvements?

I checked the code, and it backports the implementations of the Linkify methods on Android 9.0 and later.

Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Oct 9, 2022
@TobiGr TobiGr merged commit 5b213a1 into TeamNewPipe:dev Oct 9, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the LinkifyCompat branch October 10, 2022 00:29
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants