Set image-minimizer to specify image width ...

[goyalyashpal]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• set the width of the image, instead of the height
  see the rationale mentioned in the linked issue

Before/After Screenshots/Screen Record

• Before:

BEFORE_SET-HEIGHT.vivaldi_O2sZYxLU3D.mp4

• After:

AFTER_SET-WIDTH.vivaldi_ES6z2h4j6t.mp4

Fixes the following issue(s)

• Fixes [Meta] Image-minimizer wrong behaviour #9469 for portrait like orientations

Testing

• Try adding the test images at https://github.com/yashpalgoyal1304/NewPipe/issues/1
• And for resizing the viewerport: use "Device Toolbar" in the browser's dev tools,
• ... which in chromium is triggered by: in caret arrow notation](https://en.wikipedia.org/wiki/Caret_notation): ^↑i > ^↑m or say in Emacs notation: C-I > C-M

Due diligence

• I read the contribution guidelines.

[goyalyashpal]

I have made the value to result in exactly current behaviour for the default available landscape width, however I do think there's scope of improvement there - as the white landscape image looks so gigantic compared with the full portrait screenshot.

Update: 've added the improvement as Math.min( )

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[Stypox]

Thanks! I was wondering whether there was a fix for this, too :-)

[goyalyashpal]

hey, while testing for these changes in my own repo, i changed the actions settings - but now, i can't remember what the defaults were, so, can u please guide on what i should set these settings to:

[Stypox]

"Allow all actions", I think

[goyalyashpal]

okay! 🤝