Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid wrong @Nullable and @NotNull annotation imports #9474

Merged
merged 2 commits into from Nov 28, 2022
Merged

Forbid wrong @Nullable and @NotNull annotation imports #9474

merged 2 commits into from Nov 28, 2022

Conversation

evermind-zz
Copy link
Contributor

@evermind-zz evermind-zz commented Nov 28, 2022 •
edited by Stypox

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • checkstyle: declare org.jetbrains and javax.annotation Nullable's and NotNull/Nonnull as illegal imports

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox Stypox changed the title checkstyle: declare org.jetbrains and javax.annotation Nullable's and… Forbid wrong @Nullable and @NotNull annotation imports Nov 28, 2022
Stypox
Stypox approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ;-)
I made a small reformatting and also added RxJava3 imports, as Android Studio likes to suggest those, too.

@Stypox Stypox merged commit 60671c9 into TeamNewPipe:dev Nov 28, 2022
@TobiGr
Copy link
Member

TobiGr commented Nov 28, 2022

We should add something similar to the extractor

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stypox Stypox mentioned this pull request Nov 28, 2022
Merged
3 tasks
@Stypox
Copy link
Member

Stypox commented Nov 28, 2022

I opened TeamNewPipe/NewPipeExtractor#989

@AudricV AudricV added the meta Related to the project but not strictly to code label Nov 28, 2022
@Stypox Stypox mentioned this pull request Jan 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evermind-zz @TobiGr @Stypox @AudricV