Update NewPipeExtractor and properly linkify comments #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
force-pushed
the
update-npe
branch
2 times, most recently
from
393499f
to
29fca1a
Compare
Stypox
force-pushed
the
update-npe
branch
3 times, most recently
from
8325bc0
to
608c2fa
Compare
TobiGr
reviewed
Jan 15, 2023
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
SameenAhnaf
added
the
codequality
TobiGr
previously approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Code looks good. I tested briefly and did not find any bugs related to the changed linking.
There are a few bugs related to other extractor PRs which are introduced to NP in this PR, but are fixed separately. The extractor version can be updated independently.
|
I'm merging this now so that we can have it in the RC |
|
we should also update the extractor commit. otherwise, there will be reports about broken comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Descriptionand not aStringanymoreTextLinkifier:DescriptionFragmenttoTextLinkifierTextLinkifierto not contain the redundant "link" word already contained in "Linkifier"TextLinkifiermethods to be notified when the text has been set to theTextView, needed to set ellipsis and movement method in commentsTextLinkifieronly needs stream url and service id to generate popup-timestamps and hashtags, and since comments only have that information and not a fullInfo, now theTextLinkifiermethods take those two parameters instead of an `Info.getText()does not return aSpannable, but rather aSpanned(even though inTextLinkifieraSpannableBuilderis used). This means that the text selection (i.e. the highlight that appears when tapping on links) can't be manually set by us as done before inCommentTextOnTouchListener, unfortunately.LongPressLinkMovementMethodneeds to be implemented inCommentTextOnTouchListener.Fixes the following issue(s)
It definitely fixes some problems with comments, but I couldn't find any related issue.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence