Fix reproducible builds #9709
Fix reproducible builds #9709
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm fairly confident the fix works correctly as it simply reuses the relevant AGP code (and I've tested it works). I can't guarantee it won't break if something changes in AGP though. And it's a bit ugly since it uses some kotlin functions/variables marked I'm also not that familiar with groovy, so the code could probably be written more idiomatically. |
|
@obfusk Are the Reproducible Builds people aware of this? They might want to take it up with Google. |
|
He posted the fix in the Google issue tracker: https://issuetracker.google.com/issues/231837768 |
We are ;p |
|
Nice to see that there is some personnel overlap between the two projects! |
I posted my workaround there and told them exactly what & where the problem in the AGP code is. Also: who's "he"? If you meant me, I use "they"(/them) :) |
They fixed it. Not sure when it'll be part of a new AGP release; that'll take a while longer I expect. |
|
Sorry about the "He", I sometimes forget to use "They" for people I don't know ;-) |
The |
What is it?
Description of the changes in your PR
We want to have reproducible builds on F-Droid so that they can ship our own APK signed with our keys, which would prevent some uninstalling and reinstalling when users switch sources.
All credits for the fix go to @obfusk, also see https://issuetracker.google.com/issues/231837768. It has been confirmed that this works here.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence