Larger channel cards in search results #9728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahendranv
force-pushed
the
channel_card
branch
from
758a46e
to
0399c7b
Compare
|
@Stypox Please check this small PR. |
Stypox
requested changes
Feb 7, 2023
app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt
Outdated
Show resolved
Hide resolved
mahendranv
force-pushed
the
channel_card
branch
3 times, most recently
from
05ae41c
to
75292e0
Compare
- Thumbnail larger (100dp) than the usual (92dp) throughout the app - Description lint count is 8 (normally 3)
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
These changes take effect when card mode is selected for item view.
This card is NOT applicable for subscriptions list fragment
Thumbnail larger (100dp) than the usual (92dp) throughout the app
More similar to List item with more description content
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Fixes Card mode when showing channel list item search results #9703
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence