Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ExoPlayer to 2.18.5 #9890

Merged
merged 2 commits into from Apr 3, 2023
Merged

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Mar 6, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

simple version bump to current ExoPlayer release. Checked for deprecations, there were none, so no code changes necessary.
https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Mar 6, 2023
@AudricV AudricV changed the title bump ExoPlayer to 2.18.4 Bump ExoPlayer to 2.18.4 Mar 6, 2023
Copy link

@av01d1ngx4 av01d1ngx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep everything is fine.

@Redirion Redirion changed the title Bump ExoPlayer to 2.18.4 Bump ExoPlayer to 2.18.5 Mar 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't have any problem on my phone. Thanks!

@Stypox Stypox changed the base branch from dev to release-0.25.1 April 3, 2023 12:11
@Stypox Stypox merged commit 6f428d0 into TeamNewPipe:release-0.25.1 Apr 3, 2023
5 checks passed
@Stypox Stypox mentioned this pull request Apr 3, 2023
3 tasks
@Redirion Redirion deleted the bumpexo184 branch May 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants