Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YoutubeStreamLinkHandlerFactory accept channel links #524

Closed
B0pol opened this issue Jan 23, 2021 · 1 comment · Fixed by #527
Closed

YoutubeStreamLinkHandlerFactory accept channel links #524

B0pol opened this issue Jan 23, 2021 · 1 comment · Fixed by #527
Labels
bug invidious

Comments

@B0pol
Copy link
Member

B0pol commented Jan 23, 2021 •
edited
Loading

You can try with any channel/id link, https://invidio.us/channel/UCBR8-60-B28hp2BmDPdntcQ

add

        invalidUrls.add("https://www.youtube.com/channel/UCBR8-60-B28hp2BmDPdntcQ");
        invalidUrls.add("https://invidio.us/channel/UCBR8-60-B28hp2BmDPdntcQ");

in YoutubeStreamLinkHandlerFactoryTest.getIdForInvalidUrls()
@B0pol
Copy link
Member Author

B0pol commented Jan 23, 2021

Regression introduced by #394, due to the fact it was tested only for youtu.be (short URLs) and youtube.com (normal URLs), but Invidious combines both short and normal URLs with the same domain

B0pol added a commit to B0pol/NewPipeExtractor that referenced this issue Jan 23, 2021
@B0pol
fix Invidious channels being accepted by YoutubeStreamLinkHandlerFactory
00a7721 
fixes TeamNewPipe#524, see it for more details
@B0pol B0pol mentioned this issue Jan 23, 2021
Merged
3 tasks
TobiGr pushed a commit that referenced this issue Feb 5, 2021
@B0pol
fix Invidious channels being accepted by YoutubeStreamLinkHandlerFact…
44c54d4 
…ory (#527)

fixes #524, see it for more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug invidious
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Invidious channels being accepted by YoutubeStreamLinkHandlerFactory B0pol/NewPipeExtractor
1 participant
@B0pol