Obtain stream length as a Duration #1106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
the
codequality
Isira-Seneviratne
force-pushed
the
Duration
branch
from
5c3115b
to
534e2a3
Compare
Comment on lines
+81
to
+89
| public Duration getDuration() { | ||
| return duration; | ||
| } | ||
|
|
||
| public void setDuration(final long duration) { | ||
| public long getDurationInSeconds() { | ||
| return duration.toSeconds(); | ||
| } | ||
|
|
||
| public void setDuration(final Duration duration) { |
There was a problem hiding this comment.
I want to note that this is a breaking change. So the app will need to be adjusted accordingly
There was a problem hiding this comment.
Param should be annotated as @Nonnull
Comment on lines
+58
to
+61
| @Nonnull | ||
| default Duration getDuration() throws ParsingException { | ||
| return Duration.ZERO; | ||
| } |
There was a problem hiding this comment.
This could also be a breaking change.
Comment on lines
+95
to
+97
| if (duration.isZero()) { | ||
| throw new ParsingException("Could not parse duration \"" + textualDuration + "\""); | ||
| } |
There was a problem hiding this comment.
Can't duration not be uninitialized at the start and if it is still not initialized then throw the exception
There was a problem hiding this comment.
Yes, setting duration to null is a better approach here 👍
TobiGr
reviewed
Dec 29, 2023
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Show resolved
Hide resolved
TobiGr
reviewed
Dec 29, 2023
| @@ -76,11 +78,15 @@ public void setViewCount(final long viewCount) { | |||
| this.viewCount = viewCount; | |||
| } | |||
|
|
|||
| public long getDuration() { | |||
| public Duration getDuration() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract stream lengths as
Durationvalues.Durationprovides convenience methods for converting to/from different time units, e.g. seconds, hours, etc.long getDuration()->@Nonnull Duration getDuration()void setDuration(final long duration)->void setDuration(@Nonnull final Duration duration)long getDuration()->@Nonnull Duration getDuration()