[SoundCloud] Fix extraction of non-JPG images #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a possibility Some services may provide different image formats using the same suffix, without we know what format the service provide. Enforcing an image extension could so lead to provide invalid image URLs, like for SoundCloud PNG images currently. With this documentation change, it is now clear that users of this class decide of whether they want to include image extensions in the suffix. The previous behavior described in the Javadoc was not enforced.
Default image qualities were removed in image URLs with the jpg extension, causing the addition of the image suffix to full non-JPG images URLs and so to invalid image URLs. Only the image quality name with its leading "-" character and the "." character after the name is now removed and replaced by a string format replaced itself with the image quality name for each quality. As the image suffixes do not contain the image extension, the name of image qualities lists has been adapted with these changes and some related comments have been also improved.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default image qualities were removed in image URLs with the
jpgextension, causing the addition of the image suffix to full non-JPG images URLs and so to invalid image URLs.Only the image quality name with its leading
-character and the.character after the name is now removed and replaced by a string format replaced itself with the image quality name for each quality.As the image suffixes do not contain the image extension, the name of image qualities lists has been adapted with these changes and some related comments have been also improved.
The documentation of the
ImageSuffixclass has been also updated in order to reflect the change of the non-requirement of the extension in the suffix property introduced by this fix.