Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for on.soundcloud.com urls #1179

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Add support for on.soundcloud.com urls #1179

wants to merge 5 commits into from

Conversation

mjsir911
Copy link

Fixes #1178

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@TobiGr TobiGr added enhancement soundcloud service, https://soundcloud.com/ labels May 19, 2024
TobiGr
TobiGr requested changes May 19, 2024
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
I've left a few comments which should help you to clean the code.
I think it is a good idea to add tests for the on.soundcloud URLs in SoundcloudParsingHelperTest to keep track of this functionality in the future.

.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java Outdated Show resolved Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java Outdated Show resolved Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java Outdated Show resolved Hide resolved
...bi/newpipe/extractor/services/soundcloud/linkHandler/SoundcloudStreamLinkHandlerFactory.java Outdated Show resolved Hide resolved
@mjsir911
Copy link
Author

I'm not sure what's going on with the failing tests.

@mjsir911 mjsir911 requested review from AudricV and TobiGr May 30, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV Awaiting requested review from AudricV

@TobiGr TobiGr Awaiting requested review from TobiGr

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement soundcloud service, https://soundcloud.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for on.soundcloud.com
3 participants
@mjsir911 @TobiGr @AudricV