Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bandcamp] Update artist page detection #1199

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

fynngodau
Copy link
Member

Bandcamp changed the way the footer is rendered. Therefore, we check for a link to the cart page instead.

One of the artists that was tested for has seemingly removed all their tracks; hence we delete the test that checks for one of their tracks.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Bandcamp changed the way the footer is rendered. Therefore, we check for
a link to the cart page instead.
@fynngodau fynngodau added bandcamp service, https://bandcamp.com tests Issues and PR related to unit tests labels Jul 21, 2024
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr merged commit 4aaab63 into dev Jul 21, 2024
3 of 4 checks passed
@TobiGr TobiGr deleted the bandcamp-update-artist-detection branch July 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bandcamp service, https://bandcamp.com tests Issues and PR related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants