Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for invidio.us links #128

Closed
wants to merge 1 commit into from
Closed

support for invidio.us links #128

wants to merge 1 commit into from

Conversation

anoymouserver
Copy link

@anoymouserver anoymouserver commented Nov 23, 2018

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

I adapted the link support of hooktube.com for invidio.us which closes #123 and refs TeamNewPipe/NewPipe#1900.

@TobiGr
Copy link
Member

TobiGr commented Nov 23, 2018

Hello @anoymouserver,
thanks for taking a look at invidious support. To test your extractor changes with NewPipe, you can follow our documentation.

@ghost
Copy link

ghost commented Nov 23, 2018 via email

@anoymouserver
Copy link
Author

Sorry, but currently I can't install Android Studio here, so it will be kinda difficult to test my changes. I was hoping that some of you could do this. 😊

@wb9688 I've already done this in TeamNewPipe/NewPipe#1900.

The Travis build failed while running YoutubeSearchExtractorDefaultTest which I haven't even touched..?

@ghost
Copy link

ghost commented Nov 23, 2018 via email

@theScrabi
Copy link
Member

Sorry, but currently I can't install Android Studio here, so it will be kinda difficult to test my changes. I was hoping that some of you could do this.
--

issue has been resolved, extractor is compatible with frontend again.

@theScrabi
Copy link
Member

closing in favour of #132

@theScrabi theScrabi closed this Jan 20, 2019
@connectety connectety mentioned this pull request Jan 27, 2019
3 tasks
@anoymouserver anoymouserver deleted the patch-1 branch January 28, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants