Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Fix extraction of age restricted videos #665

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jun 23, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

sts is no longer required so we no longer request /embed/:id to get sts

See ytdl-org/youtube-dl#29333

Closes #666, closes TeamNewPipe/NewPipe#6403

@B0pol B0pol force-pushed the agerestricted branch 4 times, most recently from e7db514 to 08278a2 Compare June 23, 2021 09:37
@B0pol B0pol added bug youtube service, https://www.youtube.com/ labels Jun 23, 2021
@B0pol B0pol force-pushed the agerestricted branch 2 times, most recently from de071dd to c6fbd76 Compare June 23, 2021 10:18
@AudricV
Copy link
Member

AudricV commented Jun 23, 2021

The sts param is required to get cipher protected URLs: if some age-restricted URLs have signature ciphers, streams will return 403. So you should keep the sts param (I fixed its extraction in #604, don't fix it in this PR).

@B0pol
Copy link
Member Author

B0pol commented Jun 23, 2021

The sts param is required to get cipher protected URLs: if some age-restricted URLs have signature ciphers, streams will return 403. So you should keep the sts param (I fixed its extraction in #604, don't fix it in this PR).

but sts is empty. it should be re-added if fixed IMO. Otherwise we'll be doing an useless request everytime there is an age restricted video / geo restricted / not available…

@TobiGr
Copy link
Member

TobiGr commented Jun 23, 2021

Does the sts extraction work for some videos? If that is the case, we should re-add the line. Otherwise, that can be done in #604

@B0pol
Copy link
Member Author

B0pol commented Jun 23, 2021

No because the regex changed.

fixed (in #604).

Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing and this PR can be merged.

@B0pol B0pol merged commit 3966178 into TeamNewPipe:dev Jun 23, 2021
@B0pol B0pol deleted the agerestricted branch June 23, 2021 19:07
@AudricV AudricV changed the title [youtube] Fix extraction of age restricted videos [YouTube] Fix extraction of age restricted videos Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException on specific Video All types of age-gated videos don't get loaded
3 participants