-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about supported devices #161
base: master
Are you sure you want to change the base?
Conversation
Let's first check if OP is still interested in this 2-year-old PR. @tbm? |
Honestly I'm not too keen on putting in more time on this. I'd prefer it if @mhmdanas could take the PR, make the changes proposed and commit it. I didn't end up using NewPipe so you're in a better position to add this info. But if my input is required, I can try to update the PR. |
That's fine. We'll take over. Thanks for the PR, though! |
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested locally.
@@ -0,0 +1,10 @@ | |||
--- | |||
categories: | |||
- player |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really have anything to do with the player. What categor(y|ies) should we use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no better category imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned before, we could change it to "supported devices" and be done with it.
Fixes #152