Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about supported devices #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tbm
Copy link
Contributor

@tbm tbm commented Jun 4, 2020

Fixes #152

@triallax triallax self-requested a review July 17, 2022 17:18
_faq/supported-devices.html Outdated Show resolved Hide resolved
_faq/supported-devices.html Outdated Show resolved Hide resolved
@opusforlife2
Copy link
Collaborator

Let's first check if OP is still interested in this 2-year-old PR. @tbm?

@tbm
Copy link
Contributor Author

tbm commented Sep 1, 2022

Honestly I'm not too keen on putting in more time on this. I'd prefer it if @mhmdanas could take the PR, make the changes proposed and commit it.

I didn't end up using NewPipe so you're in a better position to add this info.

But if my input is required, I can try to update the PR.

@opusforlife2
Copy link
Collaborator

That's fine. We'll take over. Thanks for the PR, though!

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally.

@@ -0,0 +1,10 @@
---
categories:
- player
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really have anything to do with the player. What categor(y|ies) should we use here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no better category imo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned before, we could change it to "supported devices" and be done with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ: does it support tablets?
4 participants