Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix the website slideshow #212

Open
fbruetting opened this issue Dec 26, 2020 · 3 comments · May be fixed by #214
Open

Please fix the website slideshow #212

fbruetting opened this issue Dec 26, 2020 · 3 comments · May be fixed by #214

Comments

@fbruetting
Copy link

Endless auto-pagination and correspondent resizing of the slideshow makes it's content and everything below really awkward to read.

Additionally, when manually clicking on a pagination-arrow, the slideshow should stop and only work manually. Otherwise it's absolutely terrible to read while the content swaps way too fast.

@TobiGr TobiGr transferred this issue from TeamNewPipe/NewPipe Dec 26, 2020
@Poolitzer
Copy link
Member

Hi, you asked for an unspecific fix. I can understand the one you suggest for your second paragraph, but is there something to fix for the first one?

@fbruetting
Copy link
Author

fbruetting commented Dec 27, 2020

It would be nice if you could size the slideshow according to the content with the largest size. Then both the slideshow arrows as the content below would not be repositioned every 3 seconds.

I would also slow it down to at least 10 seconds holding time! You have to consider older and foreign people, which need way more time for reading. And they also deserve this splendid application. 😉

@Poolitzer Poolitzer linked a pull request Dec 30, 2020 that will close this issue
@Poolitzer
Copy link
Member

I made it so that when you press on the buttons, the sliding stops. I also increased the sliding time in the "download" carousel, but not in the "What other people think" one because they dont think enough (speak: the text in these slides isn't long) for this change to make sense there.

What I am unable to do is change the hight of the slides so that the arrows are set on the same size. In theory the change is relativly easy, its just this parameter:

#download-info-carousel-container {

The issue is that the QR code is hidden by default in the mobile view which is great, but it requires the arrrows to jump when you unhide it, and this is too much JS for my liking (I dont like JS).

So someone else has to do that change. Have fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants