Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme added #28

Merged
merged 3 commits into from Oct 14, 2022
Merged

Dark Theme added #28

merged 3 commits into from Oct 14, 2022

Conversation

Anuran12
Copy link
Contributor

Close: #26

image
image
image

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
opencampus-page ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 5:46PM (UTC)

@Anuran12
Copy link
Contributor Author

Please don't marge this issue before 31 October .

@thatsuman
Copy link
Member

Please don't marge this issue before 31 October .

Why?

@Anuran12
Copy link
Contributor Author

Because i am participating in a contest "Hacksquad". there the maintainers are disqualifing teams for dummy project prs. I guess its a dummy project . that's why :(

@Anuran12
Copy link
Contributor Author

@thatsuman

image

@Anuran12
Copy link
Contributor Author

well, well, you can add this. because one of my dark-mode pr was approved by them. so I hope they will not delete this too. @thatsuman

@Anuran12
Copy link
Contributor Author

Afterall I did hardwork to make this dark-mode too

@Anuran12 Anuran12 reopened this Oct 14, 2022
@thatsuman
Copy link
Member

Who told you this is a dummy project? Please check out our organization. This repo is a Landing website of our campus management system 'OpenCampus' . We're following every Hacktoberfest rules so that people like you and me can contribute to this project.
Also we are not accepting any low quality code contribution as we respect contributors hard work.
Please spare me some time so that I can review the changes.
Thanks!

@Anuran12
Copy link
Contributor Author

@thatsuman Sorry I did not know that... If you want any frontend work on this website.. I would like to work on those... Thanks

@thatsuman
Copy link
Member

@Anuran12 Please don't be sorry. I'm a developer same as you and in open source community I believe we must help and learn from each other.
Can you please check the toggle button? after enabling dark theme there's no way to disable the dark theme.

@Anuran12
Copy link
Contributor Author

Yea i check that too. I don't know why it's happening. In my local host it's working properly...

@@ -0,0 +1,10 @@
var icon = document.getElementById("theme-icon");

icon.onclick = function(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try with by using arrow function?

@Anuran12
Copy link
Contributor Author

@thatsuman still not working 🥲.

in my localhost its working

image

@thatsuman
Copy link
Member

Okay I'm merging this PR and opening another issue for this bug.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Implement dark theme for website
2 participants