New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Theme added #28
Dark Theme added #28
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Please don't marge this issue before 31 October . |
Why? |
Because i am participating in a contest "Hacksquad". there the maintainers are disqualifing teams for dummy project prs. I guess its a dummy project . that's why :( |
well, well, you can add this. because one of my dark-mode pr was approved by them. so I hope they will not delete this too. @thatsuman |
Afterall I did hardwork to make this dark-mode too |
Who told you this is a dummy project? Please check out our organization. This repo is a Landing website of our campus management system 'OpenCampus' . We're following every Hacktoberfest rules so that people like you and me can contribute to this project. |
@thatsuman Sorry I did not know that... If you want any frontend work on this website.. I would like to work on those... Thanks |
@Anuran12 Please don't be sorry. I'm a developer same as you and in open source community I believe we must help and learn from each other. |
Yea i check that too. I don't know why it's happening. In my local host it's working properly... |
dark-theme/theme.js
Outdated
@@ -0,0 +1,10 @@ | |||
var icon = document.getElementById("theme-icon"); | |||
|
|||
icon.onclick = function(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try with by using arrow function?
@thatsuman still not working 🥲. in my localhost its working |
Okay I'm merging this PR and opening another issue for this bug. |
Close: #26