Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#63 mock api category #67

Merged
merged 5 commits into from Jul 17, 2022
Merged

Feat/#63 mock api category #67

merged 5 commits into from Jul 17, 2022

Conversation

NaveOWO
Copy link
Contributor

@NaveOWO NaveOWO commented Jul 17, 2022

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 투표 페이지 mock api 연결 get 했습니당

📌 내가 알게 된 부분


📌 질문할 부분


📸 스크린샷

@NaveOWO NaveOWO requested a review from joohaem July 17, 2022 11:54
@NaveOWO NaveOWO self-assigned this Jul 17, 2022
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어용오

Comment on lines +8 to +12
type categoryType = {
id: string;
title: string;
content: string;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안쓰는 코드 지워주세요!~

@@ -1,101 +1,35 @@
import { useEffect, useState } from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지워주세요~!

Copy link
Contributor

@NYeonK NYeonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

언니 진짜 고생해써!~~!!!
언니랑 GET 같이 해서 너무 즐거웠다🥰

);
})}
{categoryLists &&
categoryLists.data.map((item: any, index: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any가 최선인가요?-??ㅎㅎㅎㅎㅎㅎ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any 다 바꿔주세요~

Copy link
Contributor

@henization henization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😍

);
})}
{categoryLists &&
categoryLists.data.map((item: any, index: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any 다 바꿔주세요~

@joohaem joohaem merged commit 990f4d1 into develop Jul 17, 2022
@joohaem joohaem deleted the feat/#63-mock_api_category branch July 17, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants