Print output to system journal, auto-rotate images and allow randomization of photo's #7
Conversation
- It only shuffles the list one time, instead of every time. - New photo's will still be shown right after arrival, and the shuffling will only take place after all new photo's have been shown
This reverts commit 3ea4c98.
- It only shuffles the list one time, instead of every time. - New photo's will still be shown right after arrival, and the shuffling will only take place after all new photo's have been shown
… in system journal
In the Telegram API v12 (which is, at time of writing, the latest available for the Raspberry Pi 3), context based callbacks got upgraded: https://github.com/python-telegram-bot/python-telegram-bot/wiki/Transition-guide-to-Version-12.0 Furthermore, the metafile writer got updated to write the parameters as strings instead of bytes (i.e. "w" instead of "wb").
As explained in the tutorial, config.py.in should be renamed to config.py. If a user failes to do this, the following error is raised: from config import * ModuleNotFoundError: No module named 'config' The deceptive nature of this errors description makes it quite difficult to troubleshoot at first sight - the module is there, it's the file we're lacking.
|
@ErwinP As people run into errors with current python, I would merge this. Then see if I would do some things differently when I upgrade my box and move to python3 (don't fix what's not broken). The main thing I'm worried about is changes to the documentation, so the .md files. I believe only RANDOMIZE_PHOTOS in config.in could be stated also in the documentation, correct? |
Thank you :) Code untill 845443a has been tested by janvangent. He ended up cloning my fork and using that, rather than applying all changes manually. @janvangent perhaps you can comment furhter?
That is correct. PS: excuse my previous comment abouth the python transition not being present in this PR; I didn't know these got updated dynamically. |
|
Merged. Thanks. Keep the PR coming if you do further improvements! |
Correct, with your changes everything works 100%! Great work |
You should know that I have no background in programming, let alone writing code in Python. Therefore, the suggested implementations might be written in a "dirty" way. It does work (it's running on 10" screen at my grandmothers house), but feel free to re-write this in a better way.
Secondly: my grandmother was very pleased with this gift - therefore: THANK YOU!