[PATCH] /notice/service/read 서비스 알림 읽음 처리 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxeol2
reviewed
Jan 12, 2022
| const { rows } = await client.query( | ||
| ` | ||
| UPDATE spark.notification | ||
| SET is_read = TRUE, read_at = now(), updated_at = now() |
There was a problem hiding this comment.
이거 dayjs 라이브러리 써서 timezone 한국으로 설정해주면 좋을 것 같아요!
There was a problem hiding this comment.
@xxeol2
아 근데 이거는 DB Timezone을 한국으로 맞춰주는게 좋을거라구 생각했어요!!
매번 코드에서 한국 시간대로 변경하는 것도 비용 낭비인거 같구, 누락되는 부분도 생길 수 있을거같아서~!!
혹시 어떻게 생각하세요~??
junghyun-jacky
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task