[FEAT] /notice/new 새로운 서비스 알림 조회 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngkwon02
added
🦋 영권
Enhancement ✨
youngkwon02
changed the title
xxeol2
approved these changes
Feb 24, 2022
| const { noticeDB } = require('../../../db'); | ||
|
|
||
| /** | ||
| * @새로운_빨콩_알림_조회 |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋ 큐티가 생명이지~~😆
Comment on lines
27
to
29
| functions.logger.error(`[ERROR] [${req.method.toUpperCase()}] ${req.originalUrl}`, `[CONTENT] ${error}`); | ||
| console.log(error); | ||
| res.status(statusCode.INTERNAL_SERVER_ERROR).send(util.fail(statusCode.INTERNAL_SERVER_ERROR, responseMessage.INTERNAL_SERVER_ERROR)); |
There was a problem hiding this comment.
그 slack 알림 메세지 연결은 나중에 하실건가요?! 갑자기 궁금!
There was a problem hiding this comment.
얼라리?.. 누락된거같아요!!! 추가해서 머지할게욥!!!
| return `('${title}', '${body}', 'Spark_IMG_URL', ${f.userId}, ${isService})`; | ||
| }); | ||
|
|
||
| pushAlarm.sendMulticastByTokens(req, res, title, body, receiverTokens, certifyingImg[0], 'enable'); | ||
| await noticeDB.addNotifications(client, notifications); | ||
| if (notifications.length > 0) { |
There was a problem hiding this comment.
이고 그냥 if(notification.length) 해줘두 될것같아요 (아주 사소한..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task