Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 현재 deleteNotification 고유성이 없음 #296

Merged
merged 14 commits into from
Mar 22, 2022
Merged

[FIX] 현재 deleteNotification 고유성이 없음 #296

merged 14 commits into from
Mar 22, 2022

Conversation

youngkwon02
Copy link
Member

✅ Default Checklist

  • check branch

  • set Labels

  • set Reviewers

📕 Task

  • 좋아요 취소시 알림 삭제에 대해 고유성 부여

@youngkwon02
refactor: 알림 조회 최근 7일 날짜 계산 방식 변경
0258ea6
@youngkwon02
comment: roomOutDELETE 보내는 알림 주석 수정
0f14a2c
@youngkwon02
feat: roomDB.endById
d5f8592
@youngkwon02
feat: 습관방의 마지막 인원이었다면, 방 END 처리
7df583f
@youngkwon02
fix: roomOutDELETE 습관방의 마지막 인원 condition
9f91179
@youngkwon02
chore: remove roomDB file log print
47337e3
@youngkwon02
chore: remove roomDB useless module import
0871e1e
@youngkwon02
refactor: roomDB getFeedRecordsByRoomIds query
465c584
@youngkwon02
refactor: 습관방 나간 사람의 피드도 조회되도록 Query 수정
16e700b
@youngkwon02
feat: 알림 조회 습관방 의존성 추가
3c4f5fe
@youngkwon02
refactor: addNotification에 room_id 값 추가
a27f7ac
@youngkwon02
refactor: 알림 생성 코드에 roomId 값 추가
7c51b01
@youngkwon02
fix: 본인이 본인 피드를 좋아하면 알림이 생성 하지 않기
eb0a5bb
@youngkwon02
fix: unlike deleteNotification 고유성 thumbnail 추가
62b3843
@youngkwon02 youngkwon02 requested a review from xxeol2 March 21, 2022 04:24
@youngkwon02 youngkwon02 self-assigned this Mar 21, 2022
xxeol2
xxeol2 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@xxeol2 xxeol2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋아요오오

@youngkwon02 youngkwon02 merged commit eb89253 into develop Mar 22, 2022
@youngkwon02 youngkwon02 deleted the fix/#294 branch March 22, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxeol2 xxeol2 xxeol2 approved these changes

Assignees

@youngkwon02 youngkwon02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youngkwon02 @xxeol2