[FEAT] POST /room 습관 방 생성 API 구현 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxeol2
reviewed
Jan 10, 2022
| * @route POST /room | ||
| * @body roomName:string, fromStart:boolean | ||
| * @error | ||
| * 1. 습관방 이름이 전달되지 않음 |
There was a problem hiding this comment.
- 습관방 이름 / 습관방 타입이 전달되지 않음
- (차후의 처리지만) userId의 유저가 userDB에 존재하지 않는 경우
- 추가하면 좋을 것 같아요!
There was a problem hiding this comment.
@xxeol2
정상적인 fromStart 값이 true 또는 false인데, falsy한 방법으로 체크하기 까다로워서 넘겨두고 까먹었네요ㅜㅜ
typeof 함수로 boolean type인지 체크하는 방식으로 타입 체크 진행하겠습니다!
감사합니다~~🙂
| const { roomName, fromStart } = req.body; | ||
|
|
||
| console.log(roomName, fromStart); | ||
|
|
youngkwon02
force-pushed
the
feature/#1
branch
from
7ec7086
to
b6a3c31
Compare
xxeol2
reviewed
Jan 10, 2022
Comment on lines
23
to
31
| // error 2. 습관방 이름이 전달되지 않음 | ||
| if (!roomName) { | ||
| return res.status(statusCode.BAD_REQUEST).send(util.fail(statusCode.BAD_REQUEST, responseMessage.NULL_VALUE)); | ||
| } | ||
|
|
||
| // error 2. 습관방 타입이 전달되지 않음 | ||
| if (typeof fromStart !== 'boolean') { | ||
| return res.status(statusCode.BAD_REQUEST).send(util.fail(statusCode.BAD_REQUEST, responseMessage.NULL_VALUE)); | ||
| } |
There was a problem hiding this comment.
if문 한 번에 조건 두개 다 넣어서 처리해도 좋을 것 같아요!
There was a problem hiding this comment.
@xxeol2
맞네여~~~ 역싀~~~ 든든합니당
xxeol2
reviewed
Jan 11, 2022
Comment on lines
46
to
50
| // error 1. 요청 권한이 없음 (회원가입 되지 않은 사용자) | ||
| // let hasAuth = userDB.checkExistById(userId); | ||
| // if (!hasAuth) { | ||
| // // 등록된 회원이 아니라는 Response | ||
| // } |
There was a problem hiding this comment.
user Check부분 제가 checkUser middleware단에 추가했어요..! 착오드려서 죄송해요!!!
There was a problem hiding this comment.
@xxeol2
아니에요~~~ㅎㅎㅎ
설희님 코드 아직 안합쳐졌지만, 미들웨어 있다고 가정하고 적용까지 완료해서 리팩터링 했습니다!!
감사합니당 👍
xxeol2
approved these changes
Jan 11, 2022
xxeol2
added a commit
that referenced
this pull request
Jan 11, 2022
xxeol2
added a commit
that referenced
this pull request
Jan 11, 2022
[FEAT] GET /room/code/:code 참여코드로 대기방 조회 API 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task
💡TODO