[GET] /myroom/:roomId 특정 습관방 사진 모아보기 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngkwon02
reviewed
Jan 16, 2022
| @@ -0,0 +1,93 @@ | |||
| const functions = require('firebase-functions'); | |||
| const admin = require('firebase-admin'); | |||
There was a problem hiding this comment.
@xxeol2
설희쌤 요녀석 안쓰이는거 같아요~~
| const statusCode = require('../../../constants/statusCode'); | ||
| const responseMessage = require('../../../constants/responseMessage'); | ||
| const db = require('../../../db/db'); | ||
| const { userDB, roomDB, sparkDB, recordDB } = require('../../../db'); |
Comment on lines
-28
to
+29
| GET_WAITROOM_DATA_IMPOSSIBLE: '참여할 수 없는 코드예요.', | ||
| GET_WAITROOM_DATA_NULL: '존재하지 않는 코드예요.', | ||
| GET_WAITROOM_DATA_IMPOSSIBLE: '참여할 수 없는 코드에요.', | ||
| GET_WAITROOM_DATA_NULL: '존재하지 않는 코드에요.', |
There was a problem hiding this comment.
이거 머지하면서 지우신게 제가 수정한 내용인데, 요거 "예요"가 맞는 문법이라구 하네용!
추가하신 내용 삭제하시구, 지우신 내용으로 대체 해주시면 될거같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task
😳 Issue