Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate #3

Merged
merged 14 commits into from
Feb 19, 2023
Merged

validate #3

merged 14 commits into from
Feb 19, 2023

Conversation

New-dev0
Copy link
Member

No description provided.

@New-dev0 New-dev0 merged commit 65a00db into TeamUltroid:ultroid Feb 19, 2023
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 19, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 16.86 🙂 16.38 🙂 -0.48 👍
Method Length 78.28 🙂 77.94 🙂 -0.34 👍
Working memory 8.92 🙂 9.09 🙂 0.17 👎
Quality 55.15% 🙂 55.17% 🙂 0.02% 👍
Other metrics Before After Change
Lines 22340 22053 -287
Changed files Quality Before Quality After Quality Change
setup.py 31.15% 😞 32.75% 😞 1.60% 👍
readthedocs/conf.py 79.22% ⭐ 79.34% ⭐ 0.12% 👍
readthedocs/custom_roles.py 80.79% ⭐ 82.45% ⭐ 1.66% 👍
telethon/entitycache.py 61.78% 🙂 61.60% 🙂 -0.18% 👎
telethon/helpers.py 75.25% ⭐ 74.49% 🙂 -0.76% 👎
telethon/password.py 56.16% 🙂 55.87% 🙂 -0.29% 👎
telethon/sync.py 83.00% ⭐ 85.17% ⭐ 2.17% 👍
telethon/utils.py 54.86% 🙂 54.75% 🙂 -0.11% 👎
telethon/version.py 100.00% ⭐ 100.00% ⭐ 0.00%
telethon/_updates/messagebox.py 59.47% 🙂 59.52% 🙂 0.05% 👍
telethon/client/account.py 81.01% ⭐ 80.85% ⭐ -0.16% 👎
telethon/client/auth.py 43.30% 😞 43.10% 😞 -0.20% 👎
telethon/client/chats.py 45.60% 😞 45.60% 😞 0.00%
telethon/client/dialogs.py 55.43% 🙂 55.04% 🙂 -0.39% 👎
telethon/client/downloads.py 48.91% 😞 49.67% 😞 0.76% 👍
telethon/client/messageparse.py 28.63% 😞 27.77% 😞 -0.86% 👎
telethon/client/messages.py 39.06% 😞 39.07% 😞 0.01% 👍
telethon/client/telegrambaseclient.py 54.11% 🙂 53.42% 🙂 -0.69% 👎
telethon/client/updates.py 47.91% 😞 47.34% 😞 -0.57% 👎
telethon/client/uploads.py 27.79% 😞 28.81% 😞 1.02% 👍
telethon/client/users.py 39.87% 😞 39.63% 😞 -0.24% 👎
telethon/crypto/aes.py 59.01% 🙂 57.83% 🙂 -1.18% 👎
telethon/crypto/factorization.py 43.98% 😞 45.21% 😞 1.23% 👍
telethon/crypto/libssl.py 59.04% 🙂 59.28% 🙂 0.24% 👍
telethon/crypto/rsa.py 85.68% ⭐ 86.26% ⭐ 0.58% 👍
telethon/errors/__init__.py 66.37% 🙂 62.52% 🙂 -3.85% 👎
telethon/errors/common.py 80.84% ⭐ 80.59% ⭐ -0.25% 👎
telethon/errors/rpcbaseerrors.py 72.38% 🙂 71.51% 🙂 -0.87% 👎
telethon/events/album.py 79.48% ⭐ 79.26% ⭐ -0.22% 👎
telethon/events/callbackquery.py 73.66% 🙂 74.05% 🙂 0.39% 👍
telethon/events/chataction.py 64.33% 🙂 64.03% 🙂 -0.30% 👎
telethon/events/common.py 78.14% ⭐ 78.12% ⭐ -0.02% 👎
telethon/events/inlinequery.py 81.23% ⭐ 81.04% ⭐ -0.19% 👎
telethon/events/messagedeleted.py 83.08% ⭐ 83.16% ⭐ 0.08% 👍
telethon/events/messageread.py 79.25% ⭐ 79.23% ⭐ -0.02% 👎
telethon/events/newmessage.py 63.57% 🙂 63.26% 🙂 -0.31% 👎
telethon/events/raw.py 78.19% ⭐ 79.57% ⭐ 1.38% 👍
telethon/extensions/binaryreader.py 83.92% ⭐ 83.45% ⭐ -0.47% 👎
telethon/extensions/html.py 38.82% 😞 39.74% 😞 0.92% 👍
telethon/extensions/markdown.py 28.00% 😞 26.00% 😞 -2.00% 👎
telethon/network/authenticator.py 20.78% ⛔ 20.78% ⛔ 0.00%
telethon/network/mtprotosender.py 61.59% 🙂 61.33% 🙂 -0.26% 👎
telethon/network/mtprotostate.py 67.64% 🙂 67.81% 🙂 0.17% 👍
telethon/network/connection/connection.py 62.98% 🙂 64.49% 🙂 1.51% 👍
telethon/network/connection/http.py 79.62% ⭐ 77.86% ⭐ -1.76% 👎
telethon/network/connection/tcpintermediate.py 93.24% ⭐ 93.47% ⭐ 0.23% 👍
telethon/sessions/memory.py 70.33% 🙂 71.45% 🙂 1.12% 👍
telethon/sessions/sqlite.py 77.70% ⭐ 77.58% ⭐ -0.12% 👎
telethon/sessions/string.py 78.90% ⭐ 76.93% ⭐ -1.97% 👎
telethon/tl/tlobject.py 60.74% 🙂 65.76% 🙂 5.02% 👍
telethon/tl/core/gzippacked.py 91.55% ⭐ 93.61% ⭐ 2.06% 👍
telethon/tl/custom/button.py 86.93% ⭐ 87.41% ⭐ 0.48% 👍
telethon/tl/custom/chatgetter.py 80.87% ⭐ 81.07% ⭐ 0.20% 👍
telethon/tl/custom/conversation.py 70.07% 🙂 70.79% 🙂 0.72% 👍
telethon/tl/custom/inlinebuilder.py 33.99% 😞 34.06% 😞 0.07% 👍
telethon/tl/custom/inlineresults.py 85.39% ⭐ 82.18% ⭐ -3.21% 👎
telethon/tl/custom/message.py 58.38% 🙂 58.03% 🙂 -0.35% 👎
telethon/tl/custom/qrlogin.py 74.38% 🙂 74.23% 🙂 -0.15% 👎
telethon/tl/custom/sendergetter.py 85.61% ⭐ 87.35% ⭐ 1.74% 👍
telethon_examples/gui.py 64.86% 🙂 64.52% 🙂 -0.34% 👎
telethon_examples/interactive_telegram_client.py 51.03% 🙂 49.47% 😞 -1.56% 👎
telethon_examples/quart_login.py 76.91% ⭐ 73.90% 🙂 -3.01% 👎
telethon_examples/replier.py 68.33% 🙂 70.09% 🙂 1.76% 👍
telethon_generator/docswriter.py 66.63% 🙂 66.98% 🙂 0.35% 👍
telethon_generator/syncerrors.py 39.58% 😞 43.62% 😞 4.04% 👍
telethon_generator/generators/docs.py 24.34% ⛔ 25.15% 😞 0.81% 👍
telethon_generator/generators/errors.py 36.87% 😞 34.70% 😞 -2.17% 👎
telethon_generator/generators/tlobject.py 33.03% 😞 33.65% 😞 0.62% 👍
telethon_generator/parsers/errors.py 69.85% 🙂 69.99% 🙂 0.14% 👍
telethon_generator/parsers/methods.py 66.10% 🙂 66.14% 🙂 0.04% 👍
telethon_generator/parsers/tlobject/parser.py 46.44% 😞 43.55% 😞 -2.89% 👎
telethon_generator/parsers/tlobject/tlarg.py 63.11% 🙂 62.50% 🙂 -0.61% 👎
telethon_generator/parsers/tlobject/tlobject.py 62.77% 🙂 61.36% 🙂 -1.41% 👎
tests/readthedocs/quick_references/test_client_reference.py 80.72% ⭐ 81.33% ⭐ 0.61% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
telethon_generator/generators/docs.py _write_html_pages 131 ⛔ 1634 ⛔ 0.04% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
telethon/tl/custom/message.py Message.click 96 ⛔ 354 ⛔ 3.42% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
setup.py generate 51 ⛔ 378 ⛔ 6.94% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
telethon/client/messages.py _MessagesIter._init 52 ⛔ 553 ⛔ 20 ⛔ 7.23% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
telethon_generator/generators/tlobject.py _write_modules 58 ⛔ 426 ⛔ 18 ⛔ 8.56% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant