Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Vertical alignment of chips and input incorrect #285

Open
CrocoDillon opened this issue Aug 4, 2019 · 4 comments
Open

Vertical alignment of chips and input incorrect #285

CrocoDillon opened this issue Aug 4, 2019 · 4 comments

Comments

@CrocoDillon
Copy link

Chips and input should be center aligned vertically but they are not. The offset is only small with normal chips but with small chips it's very obvious.

Sandbox: https://codesandbox.io/s/material-ui-chip-input-input-alignment-uvftp

Enter some data in the input field to see what I mean.

@leMaik
Copy link
Member

leMaik commented Aug 4, 2019

Awesome! Added complexity due to small chips. 🙄

We now have three input variants (normal, outlined, filled), two chip variants (small, normal) and three margins (normal, dense, none). That's 18 variants to check. I'll look into this soon and make a storybook example with all 18 cases.

@leMaik leMaik added the bug label Aug 4, 2019
@CrocoDillon
Copy link
Author

CrocoDillon commented Aug 4, 2019

Yeah I figured when doing some testing on Code Sandbox (never used it before btw, it's awesome) that small chips are new in Material UI v4.

Also... it's 2019 and still vertical alignment can be a challenge 😆 Though flexbox does ease the pain a little bit in most cases.

@leMaik
Copy link
Member

leMaik commented Aug 4, 2019

Also... it's 2019 and still vertical alignment can be a challenge

Yeah, it's mostly a chip margin and line height thing here.

@hermanho
Copy link

hermanho commented Nov 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants