Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Consider clsx instead of classnames #283

Closed
CrocoDillon opened this issue Jul 31, 2019 · 6 comments
Closed

Consider clsx instead of classnames #283

CrocoDillon opened this issue Jul 31, 2019 · 6 comments

Comments

@CrocoDillon
Copy link

Material UI uses clsx instead of classnames since v4, see mui/material-ui/pull/14152 for reasons and discussion.

Might make sense to start using clsx for material-ui-chip-input as well to make sure it isn't the reason people end up with two class name utilities in their bundles. Should be a drop-in replacement, I can make a PR if desired.

Related: #275 #280

@leMaik
Copy link
Member

leMaik commented Jul 31, 2019

Thanks for the reminder, I'd like to use clsx for our v4-compatible version. 👍 Would you maybe like to continue the work on #280? Unfortunately, there's not much progress lately.

@CrocoDillon
Copy link
Author

Great! I might have time in the weekend or early next week to look at it if there is still little progress by then 😄

@leMaik
Copy link
Member

leMaik commented Aug 3, 2019

@CrocoDillon The work on the Material-UI v4 support continues on the next branch. 😎 I replaced classnames with clsx there. Thanks to #280, it already looks pretty nice, I'll release a beta version later.

If you find any bugs in the new version, your help would be highly appreciated. We don't use v4 in any project yet, unfortunately.

@leMaik leMaik closed this as completed Aug 3, 2019
@CrocoDillon
Copy link
Author

Okay great, looking forward to the release.

I do have issues with vertical alignment (seems to be caused by #278). Vertical alignment of the chips with the input element is off. Especially when rendering a small chip. Not sure if this is Material UI v4 specific though.

@leMaik
Copy link
Member

leMaik commented Aug 4, 2019

@CrocoDillon Please open a new issue and provide a screenshot or, even better, a Code Sandbox that reproduces the issue.

@CrocoDillon
Copy link
Author

Done, see #285.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants