-
-
Notifications
You must be signed in to change notification settings - Fork 210
Consider clsx instead of classnames #283
Comments
Thanks for the reminder, I'd like to use clsx for our v4-compatible version. 👍 Would you maybe like to continue the work on #280? Unfortunately, there's not much progress lately. |
Great! I might have time in the weekend or early next week to look at it if there is still little progress by then 😄 |
@CrocoDillon The work on the Material-UI v4 support continues on the If you find any bugs in the new version, your help would be highly appreciated. We don't use v4 in any project yet, unfortunately. |
Okay great, looking forward to the release. I do have issues with vertical alignment (seems to be caused by #278). Vertical alignment of the chips with the input element is off. Especially when rendering a small chip. Not sure if this is Material UI v4 specific though. |
@CrocoDillon Please open a new issue and provide a screenshot or, even better, a Code Sandbox that reproduces the issue. |
Done, see #285. |
Material UI uses
clsx
instead ofclassnames
since v4, see mui/material-ui/pull/14152 for reasons and discussion.Might make sense to start using
clsx
formaterial-ui-chip-input
as well to make sure it isn't the reason people end up with two class name utilities in their bundles. Should be a drop-in replacement, I can make a PR if desired.Related: #275 #280
The text was updated successfully, but these errors were encountered: