This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Add delayBeforeAdd option
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your first contribution! 🎉 I'll test and merge it tomorrow, but it looks really good. 👍 |
|
Oh and yes, I think the breaking change is fine…ish. |
|
You're welcome - glad you created this library! Now that I've started to dig into the internals, there are some other changes I may start to implement. |
|
@leMaik I just took the liberty to make an additional commit to refactor some logic for clarity and to DRY some things. |
|
Hi @leMaik did you get a chance to look this over? |
|
@joelvh Thanks for the heads-up. I'll merge this now. |
saschb2b
reviewed
Feb 7, 2019
leMaik
approved these changes
Feb 7, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262 by adding an explicit
delayBeforeAddoption in order to disable use ofsetTimeoutby default. This could be a breaking change for those who are using event callbacks that conflict withonBlur. However, I assume that is the edge case and most implementations can useonBlurjust fine.@leMaik you OK with disabling the delay by default?