This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Fix 'required' prop for non-empty chip sets. #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
reviewed
Apr 22, 2020
src/ChipInput.js
Outdated
| @@ -576,7 +576,7 @@ class ChipInput extends React.Component { | |||
| [classes.marginDense]: other.margin === 'dense' | |||
| })} | |||
| error={error} | |||
| required={required} | |||
| required={chips.length ? undefined : required} | |||
There was a problem hiding this comment.
This could be changed to chips.length === 0 so that we know what this is intended to do. Let the minifier minify the code.
|
Thank you for your first contribution, @benwiley4000! 🎉 |
leMaik
approved these changes
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requiredprop triggers undesired validation errors when chips are entered, since the FormControl context tells the input field that text input is required for submission.This change sets the FormControl's
requiredstate only when the list of chips is empty. To make sure the asterisk always appears when desired, I'm passing therequiredprop to theInputLabelcomponent.