This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Update peer dependency to support React v17 with Material UI v4.11 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you but I don't want to support Material-UI v4. It has an auto complete component that supports everything that this component supports and even more. We should not re-invent the wheel. 🙃 If you need this for MUI v4, feel free to fork the project and publish a scoped package on npm. |
|
Okay, i apologize to PR this, i felt dumb. Thanks for your response. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added react & react dom
v17.0.0to support React 17 and material UIv4.11.0Tested on
react 17.0.1react-dom 17.0.1@material-ui/core 4.11.3