Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - prettier / eslint #30

Closed
goldylucks opened this issue Jun 14, 2019 · 2 comments
Closed

PR - prettier / eslint #30

goldylucks opened this issue Jun 14, 2019 · 2 comments

Comments

@goldylucks
Copy link
Contributor

while working on #28 accidentally formatted many of the files automatically through prettier. I see there's no prettier nor eslint in the project. I can add it with the config of your choice, i.e. semistandard.

I think it will make it easier to maintain/extend.

Thoughts?

@leMaik
Copy link
Member

leMaik commented Jun 15, 2019

We're already using standard linter, see [https://github.com/TeamWertarbyte/material-ui-rating/blob/master/package.json#L8](the package.json).

Is there any configuration we're missing?

@goldylucks
Copy link
Contributor Author

ohh my bad, I'm used to lint running on precommit hook. Closing this, thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants