add support for custom Component prop #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
leMaik
reviewed
Jun 15, 2019
|
Why does this have so many conflicts? Are you updating the material-ui v3 version and trying to PR it onto master? |
leMaik
requested changes
Jun 15, 2019
leMaik
approved these changes
Jun 16, 2019
|
Gotcha! Didn't know that, I was wondering really how did you pushed to my
repo :)
…On Sun, Jun 16, 2019, 21:53 Maik Marschner ***@***.***> wrote:
Merged #28 <#28>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=ABVEADF5XVXWMMRZ4TV47WDP22D3NA5CNFSM4HYNZHNKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSAA327A#event-2416033148>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVEADCD7T5JJUHZNDWEYETP22D3NANCNFSM4HYNZHNA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #27
see screenshot with working storybook below.
let me know if any revisions are needed!
btw, I had to add
babel-loaderto dev dependencies since I was getting a missing module error.