Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken downloads system #1120

Closed
lol768 opened this issue Dec 19, 2017 · 9 comments
Closed

Broken downloads system #1120

lol768 opened this issue Dec 19, 2017 · 9 comments

Comments

@lol768
Copy link

lol768 commented Dec 19, 2017

Like a bunch of other people I was caught out by the fact your webserver serves text/html in response to a perfectly legitimate curl command to a URL with a .img filename (because it doesn't have a Referer set) which I executed after copying the download link URL to the clipboard after viewing the download page. This made the subsequent signature check fail, which led me to believe the webserver had been compromised.

Please fix your downloads page. If you want users to view ads on the page first, fine: Use a different (tokenised, if necessary) URL for the actual binary and link it from the page with ads. The current implementation where you get different resources back based on your Referer header is honestly incredibly stupid, has wasted a lot of people's time (#904 #625 #931 #656) and isn't in line with how a webserver and HTTP are supposed to work.

Please sort it out.

@xerces8
Copy link

xerces8 commented Feb 11, 2018

I'll add my case here, as there are already enough tickets opened.

I tried to download TWRP 3.2.1 for i9300 (this URL: https://eu.dl.twrp.me/i9300/twrp-3.2.1-0-i9300.img.html )
And ... it didn't work.
In the default LineageOS browser, just nothing happens after tapping the link.
I thought that browser is "too simple" , so I installed Firefox.
Same story. After tapping the download link a "download started" message pops up, but then nothing. If I open the "Downloads" menu, the download is listed, with a "failed" remark.

I also tried on another phone (MIUI) using Chrome. Same.

At the end I downloaded the file under Windows on my PC.

Please attend to this issue and fix it.
Thank you.

@shaggyskunk
Copy link

shaggyskunk commented Feb 11, 2018 via email

@xerces8
Copy link

xerces8 commented Feb 11, 2018

I used Windows as an interim solution.

@shaggyskunk
Copy link

shaggyskunk commented Feb 11, 2018 via email

@rancidfrog
Copy link

How is this not being addressed?
None of my browsers are able to download img file. They all download html instead.

Horrible solution that does not seem to work, unless for the 2 cases of samsung and Microsoft being your official sponsors

@bigbiff
Copy link
Member

bigbiff commented May 28, 2019

Closing as wontfix

@bigbiff bigbiff closed this as completed May 28, 2019
@rancidfrog
Copy link

@bigbiff

This is silly.
Finally was able to download with curl:

curl -e https://dl.twrp.me/polaris/twrp-3.2.3-0-polaris.img.html  -L  -O https://dl.twrp.me/polaris/twrp-3.2.3-0-polaris.img

@lol768
Copy link
Author

lol768 commented May 29, 2019

Closing as wontfix

Poor response to a legitimate bug.

@lol768
Copy link
Author

lol768 commented Jun 29, 2019

Pixel 2:

$ curl -e https://dl.twrp.me/walleye/twrp-3.3.0-0-walleye.img.html  -L  -O https://dl.twrp.me/walleye/twrp-3.3.0-0-walleye.img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants