Openrecoveryscript not executed on A/B devices

[apaolino]

• [ x] I am running an official build of TWRP, downloaded from https://twrp.me/Devices/
• [ x] I am running the latest version of TWRP
• [ x] I have read the FAQ (https://twrp.me/FAQ/)
• [ x] I have searched for my issue and it does not already exist

Device codename: Tissot
TWRP version: 3.2.3-1

WHAT STEPS WILL REPRODUCE THE PROBLEM?

create /cache/recovery/openrecoveryscript file with some commands inside

WHAT IS THE EXPECTED RESULT?

TWRP should execute the script being aware that since it's a A/B device the /cache partition is not used, so it could read from /data/cache/openrecoveryscript

WHAT HAPPENS INSTEAD?

TWRP ignores openrecoveryscript file

[arjanvlek]

Also facing this issue. Anyone knows if TWRP searches on another location on a/b devices to execute the script?

[CaptainThrowback]

It doesn't. This support will need to be added to TWRP.

[arjanvlek]

Ok. Sorry to ask a noob question, but would checking a second location - if the 1st one does not exist - within openrecoveryscript.cpp suffice? As it copies the script to SCRIPT_FILE_TMP afterwards i dont think the cache partition is needed anywhere else.
If i were to do so, how can i submit this as PR so it can be reviewed & released? In this repo or the "bootable_android_recovery" repo?

[CaptainThrowback]

You submit changes via Gerrit. See here: https://github.com/omnirom/android/blob/android-9.0/README.md

[tukusejssirs]

This is an issue with TWRP 3.2.3-1 on OnePlus 3T (oneplus3), too. Anyways, what is the correct file: /cache/recovery/command or /cache/recovery/openrecoveryscript?

[apaolino]

twrp uses /cache/recovery/openrecoveryscript