Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Added ability to set quaternion directly #236

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Added ability to set quaternion directly #236

merged 2 commits into from
Apr 4, 2019

Conversation

sainsay
Copy link
Contributor

@sainsay sainsay commented Apr 4, 2019

Simply put. it adds the ability to use quaternion values when setting the rotation.

use by Maya to sync rotation properly

LaisoEmilio
LaisoEmilio approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@LaisoEmilio LaisoEmilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider translating our rotation radiants values directly into quaternion when set, instead, but for the time being this is good as well.

DBouma
DBouma approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@DBouma DBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@LaisoEmilio LaisoEmilio merged commit 3790979 into master Apr 4, 2019
@sainsay sainsay deleted the feature_rotation_quat branch April 4, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LaisoEmilio LaisoEmilio LaisoEmilio approved these changes

@DBouma DBouma DBouma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sainsay @LaisoEmilio @DBouma