This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Direct GI #272
Merged
Direct GI #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nielsbishere
suggested changes
May 7, 2019
resources/shaders/path_tracer.hlsl
Outdated
|
|
||
| //prefiltered_color * (kS * sampled_brdf.x + sampled_brdf.y); | ||
| return shadow_mult * (light_intensity * (NdotL * spec + NdotL * albedo / M_PI)); | ||
| return shadow_mult * (kD * albedo / PI + spec) * light_intensity * NdotL; |
There was a problem hiding this comment.
Why is there two returns here?
resources/shaders/path_tracer.hlsl
Outdated
| @@ -96,7 +96,7 @@ float4 TraceColorRay(float3 origin, float3 direction, unsigned int depth, unsign | |||
| RayDesc ray; | |||
| ray.Origin = origin; | |||
| ray.Direction = direction; | |||
| ray.TMin = EPSILON; | |||
| ray.TMin = 0; | |||
There was a problem hiding this comment.
Won't this cause self-intersection?
There was a problem hiding this comment.
Nvm, see you added it to the origin
| float exposure = 1; | ||
|
|
||
| float3 color = input[DTid.xy].rgb / (frame_idx); | ||
| float3 color = input[DTid.xy].rgb / (frame_idx + 1); |
There was a problem hiding this comment.
Why do you divide by frame_idx? Means the color would be divided by 1, then 2, then 3?
There was a problem hiding this comment.
Hmm, I guess the var name is correct, but frame_idx is also referenced to as the current render index
resources/shaders/path_tracer.hlsl
Outdated
| // #################### GGX ##################### | ||
| uint light_count = lights[0].tid >> 2; | ||
| int light_to_sample = min(int(nextRand(seed) * light_count), light_count - 1); | ||
| Light light = lights[light_to_sample]; |
There was a problem hiding this comment.
What if there's no lights available?
There was a problem hiding this comment.
Good point. Forgot about that case.
Nielsbishere
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added direct GI from before the vacation.