Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryParse should be used instead of Parse. #42

Closed
Cosmin-Parvulescu opened this issue Jul 7, 2014 · 0 comments
Closed

TryParse should be used instead of Parse. #42

Cosmin-Parvulescu opened this issue Jul 7, 2014 · 0 comments
Labels
bug enhancement

Comments

@Cosmin-Parvulescu
Copy link
Collaborator

Parse will throw an exception which is not caught and will crash.
Instead TryParse should be used with nullable values.

Ex. https://github.com/TeamnetGroup/cap-net/blob/master/src/CAPNet/XmlParser.cs#L127
vgrigoriu added a commit that referenced this issue Jul 8, 2014
@vgrigoriu
Merge pull request #43 from StanculescuDaniel/master
25973ff 
This fixes #42 and resolves #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cosmin-Parvulescu