Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method for uploading files #5

Merged
merged 12 commits into from Sep 6, 2021
Merged

Added method for uploading files #5

merged 12 commits into from Sep 6, 2021

Conversation

Da9elKH
Copy link
Contributor

@Da9elKH Da9elKH commented Apr 22, 2021

  • Added Teamtailor#upload and client#create_uploads
  • Added rspec for parsing uploads

@bzf
Copy link
Member

bzf commented Apr 26, 2021

@Da9elKH Could you rebase this against main and remove the commits that are already merged and I'll have a look afterwards 😊 👍🏽

@Da9elKH
Copy link
Contributor Author

Da9elKH commented Apr 29, 2021

@Da9elKH Could you rebase this against main and remove the commits that are already merged and I'll have a look afterwards 😊 👍🏽

I will look into that next week! I have not removed commits before, but I guess I will figure it out! 😅

@bzf
Copy link
Member

bzf commented Apr 30, 2021

@Da9elKH They should disappear when you rebase by themselves. 😄

If you want some help on that topic, Upcase has a video series about using git that really helped me understand some of the more complicated parts of it. There's an episode focused on rebasing which could be interesting for you, so I'll leave it here if you want to check it out 😊

https://thoughtbot.com/upcase/videos/git-crafting-history

@Da9elKH
Copy link
Contributor Author

Da9elKH commented Aug 27, 2021

@Da9elKH They should disappear when you rebase by themselves. 😄

If you want some help on that topic, Upcase has a video series about using git that really helped me understand some of the more complicated parts of it. There's an episode focused on rebasing which could be interesting for you, so I'll leave it here if you want to check it out 😊

https://thoughtbot.com/upcase/videos/git-crafting-history

I think the previous commits are gone now, and hope you can see if this change can be approved when you have time :)

@Da9elKH
Copy link
Contributor Author

Da9elKH commented Sep 6, 2021

@bzf What is the status of this pull request? :)

@bzf bzf merged commit b2218c5 into Teamtailor:main Sep 6, 2021
@bzf
Copy link
Member

bzf commented Sep 6, 2021

@Da9elKH Sorry, I was planning to look at it last week. 🙈

Everything looks good to me, great work! 🎉

I'll merge it in and will do a release during the day, thanks for the contribution 😄

@bzf
Copy link
Member

bzf commented Sep 6, 2021

Released in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants