Port StripFileExtensions from Desk

[gangleri]

Copy StripFileExtensions from Desk so that it can be used in Spaces
and other projects

• Add Sanitize middleware
• Add tests
• Update Gopkg.lock to include echo so tests can be run

[codecov]

Codecov Report

Merging #24 into master will decrease coverage by 0.19%.
The diff coverage is 55.55%.

@@            Coverage Diff            @@
##           master      #24     +/-   ##
=========================================
- Coverage   59.78%   59.59%   -0.2%     
=========================================
  Files          11       12      +1     
  Lines         378      396     +18     
=========================================
+ Hits          226      236     +10     
- Misses        127      132      +5     
- Partials       25       28      +3

Impacted Files	Coverage Δ
sanitizeMiddleware/sanitize.go	55.55% <55.55%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d01d64...7cb9889. Read the comment docs.

[arp242]

I don't think we should port this to be honest. It's an ugly hack. I have never happy with it in Desk either, and the only reason we added it in Desk was because we were supposed to move away from adding .json to all our endpoints.

It would be better to either simply not use .json (easiest), or fix echo's router or swap it for something else (harder).

[ready4god2513]

We don't get the choice to not use .json. It's something that's been decided on. So now we need to support it everywhere.

[arp242]

Then someone should fix the echo router. Adding middlewares is very annoying because it adds two entries to the stack trace on any error. It's already almost two pages in a full-screen terminal on my screen. Every time I have an error I need to scroll up. Very annoying when trying to fix stuff.

The only reason my PR got reverted is because it had a bug, so if someone fixes that, then we can just use the echo router.

[ready4god2513]

Sure. We can do that. But the spaces team needs this in the mean time.

…

On Tue, Apr 17, 2018 at 4:05 PM Martin Tournoij ***@***.***> wrote: Then someone should fix the echo router. Adding middlewares is very annoying because it adds two entries to the stack trace on any error. It's already almost two pages in a full-screen terminal on my screen. Every time I have an error I need to scroll up. Very annoying when trying to fix stuff. The only reason my PR got reverted is because it had a bug, so if someone fixes that, then we can just use the echo router. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHbUqIJwKuNfZgXIoUAPkWtXt85SxU2ks5tpnUrgaJpZM4TY7J_> .

[arp242]

This should be in echoutil btw, as we use this package in some projects that don't use echo, and this will add echo as a dependency.

[gangleri]

Closing this PR as it's been replaced by https://github.com/Teamwork/echoutil/pull/11