Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to audit json.Unmarshal failures #27

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Apr 26, 2018

Still got a bunch of those for some reason:
https://sentry.io/teamwork/launchpad/issues/525470346

Seems to be on /v1/logout.json; but when I test it my browser doesn't
send up a Content-Type: application/json header or request body?

Maybe some context will help.

Still got a bunch of those for some reason:
https://sentry.io/teamwork/launchpad/issues/525470346

Seems to be on `/v1/logout.json`; but when I test it my browser doesn't
send up a `Content-Type: application/json` header or request body?

Maybe some context will help.
@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #27 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   59.13%   58.98%   -0.16%     
==========================================
  Files          11       11              
  Lines         372      373       +1     
==========================================
  Hits          220      220              
- Misses        127      128       +1     
  Partials       25       25
Impacted Files Coverage Δ
auditMiddleware/audit.go 48.38% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97effcb...0b52500. Read the comment docs.

@arp242 arp242 merged commit 2447f5d into master Apr 26, 2018
@arp242 arp242 deleted the audit-ctx branch April 26, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants