Add middlware to block access to "hidden" dot-files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For https://github.com/Teamwork/desk/pull/2674 Also add a test for the existing path traversal middleware. I put them both in `staticMiddlware` instead of making a separate package for 'em. Seemed to make more sense to me,
arp242
force-pushed
the
block-dotfiles
branch
from
f55d5c6
to
e359f9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 78.29% 78.78% +0.49%
==========================================
Files 4 5 +1
Lines 129 165 +36
==========================================
+ Hits 101 130 +29
- Misses 24 29 +5
- Partials 4 6 +2
Continue to review full report at Codecov.
|
| {"/some/./path", 200}, | ||
| {"/some/path/.hidden", 404}, | ||
| {"/some/path/.hidden/file", 404}, | ||
| {"/.some/path/hidden/file", 404}, |
There was a problem hiding this comment.
Should add a test for valid extensions just to make sure this doesn't get broken:
"/some/file.json", 200
arp242
force-pushed
the
block-dotfiles
branch
from
3ee945a
to
bfc9366
Compare
ready4god2513
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/Teamwork/desk/pull/2674
Also add a test for the existing path traversal middleware.
I put them both in
staticMiddlwareinstead of making a separatepackage for 'em. Seemed to make more sense to me,