Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store notifications. #180

Merged
merged 1 commit into from
May 22, 2023
Merged

Store notifications. #180

merged 1 commit into from
May 22, 2023

Conversation

fishinthecalculator
Copy link
Collaborator

Closes #116

@fishinthecalculator fishinthecalculator marked this pull request as ready for review December 6, 2022 01:02
@fishinthecalculator fishinthecalculator force-pushed the store_notifications branch 2 times, most recently from a7e7b05 to 8d7a054 Compare December 7, 2022 23:23
@fishinthecalculator fishinthecalculator requested review from chobeat and removed request for chobeat December 11, 2022 12:04
chobeat
chobeat requested changes Dec 11, 2022
View reviewed changes
Copy link
Member

@chobeat chobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on new master and please fix your linter. A lot of the edits, as found out before, are just reformatting with a different standard. Check why your pre-commit-hook is behaving like this.

@fishinthecalculator fishinthecalculator force-pushed the store_notifications branch 4 times, most recently from 515d1f2 to 39bf25f Compare May 14, 2023 11:58
@fishinthecalculator
Copy link
Collaborator Author

@chobeat I shoud have removed all the linting noise. This PR is based on #183 and should be merged after it

@fishinthecalculator fishinthecalculator merged commit 6bd2d60 into master May 22, 2023
1 check passed
@fishinthecalculator fishinthecalculator deleted the store_notifications branch May 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chobeat chobeat chobeat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store notifications
2 participants
@fishinthecalculator @chobeat