Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastHTTP Should be only 1 directory #1996

Closed
msmith-techempower opened this issue Mar 25, 2016 · 4 comments
Closed

FastHTTP Should be only 1 directory #1996

msmith-techempower opened this issue Mar 25, 2016 · 4 comments

Comments

@msmith-techempower
Copy link
Member

Currently, there are two directories (mysql and postgresql), but these should be one dir with separate test/code as necessary. The current implementation has JSON/Plaintext tests implemented by both, but without any difference.

@valyala Could you give a hand refactoring these?
@valyala
Copy link
Contributor

valyala commented Mar 25, 2016

@msmith-techempower , I'll look into it.

valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 29, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
4e43137 
…into fasthttp folder
valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 29, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
2443044 
…into fasthttp folder
valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 29, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
f513dc8 
…into fasthttp folder
@valyala valyala mentioned this issue Mar 29, 2016
Closed
valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 29, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
550277c 
…into fasthttp folder
valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 29, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
a7c77d0 
…into fasthttp folder
valyala added a commit to valyala/FrameworkBenchmarks that referenced this issue Mar 31, 2016
@valyala
Issue TechEmpower#1996: merge fasthttp-mysql and fasthttp-postgresql …
e495d29 
…into fasthttp folder
@NateBrady23
Copy link
Member

Can be closed once #2112 is merged

@valyala
Copy link
Contributor

valyala commented Jun 27, 2016

@nbrady-techempower , now it can be closed :)

@NateBrady23
Copy link
Member

Thanks @valyala !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valyala @NateBrady23 @msmith-techempower