Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding .net thread management #879

Closed
jchannon opened this issue Jun 22, 2014 · 3 comments
Closed

Overriding .net thread management #879

jchannon opened this issue Jun 22, 2014 · 3 comments

Comments

@jchannon
Copy link
Contributor

Why are you doing this?

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/nancy/src/Global.asax.cs#L14

@bhauer
Copy link
Contributor

bhauer commented Jun 23, 2014

Hi @jchannon. This may or may not be related to #325, although I have not refreshed my memory prior to writing this quick reply.

If memory served me correctly, the contributors who provided the test in question believed that this would improve performance. However, as with everything in this project, if there are configuration changes that improve performance (especially changes that simplify or more accurately represent the canonical configuration for a framework or platform), we'd be happy to review and incorporate those.

However, in many cases, such as this, we'd want to get at least a few of the past contributors for a particular subject matter to weigh in before making changes since we (TechEmpower) are not experts in every framework and platform this project covers and often lean on the expertise of contributors.

@kppullin
Copy link
Contributor

Hi @jchannon - I've added some details in the issue referenced by @bhauer (#877).

@hamiltont
Copy link
Contributor

@jchannon closing as this seems to be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants